+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33913/22981

• This PR adds an extra 12KB to repository

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibFormats/CastorObjects
CalibFormats/HcalObjects

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

please test

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/summary.html
COMMIT: bad537e
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33913/15465/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid #33847 @srimanob: Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid
• Use better interfaces to Geant4 #33894 @civanch: Use better interfaces to Geant4
• Code-cleanup of RPC-DQM #33854 @jhgoh: Code-cleanup of RPC-DQM

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaECALRecHitReducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaElectronTracksReducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/PUDumper.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc: In static member function 'static void SelectedElectronFEDListProducer::fillDescriptions(edm::ConfigurationDescriptions&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:719:32: error: 'desc' has incomplete type
  719 |   edm::ParameterSetDescription desc;
      |                                ^~~~
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-30-2300/src/FWCore/Framework/interface/stream/EDProducer.h:24,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.h:11,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:1:


+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33913/22990

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc modified in PR(s): Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Pull request #33913 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

please test

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15482/summary.html
COMMIT: a5198a2
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33913/15482/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15482/llvm-analysis/cmsclangtidy.txt for details.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFMuonUntagger.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFPileUp.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PdgIdPFCandidateSelector.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PtMinPFCandidateSelector.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc: In static member function 'static void PFCandidateRecalibrator::fillDescriptions(edm::ConfigurationDescriptions&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc:308:32: error: aggregate 'edm::ParameterSetDescription desc' has incomplete type and cannot be defined
  308 |   edm::ParameterSetDescription desc;
      |                                ^~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc:310:25: error: expected primary-expression before '>' token
  310 |   desc.add("pfcandidates", edm::InputTag("particleFlow"));
      |                         ^


+reconstruction

• reco changes are somewhat trivial additions of missing direct includes in CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc

+Upgrade

+l1

+1

+1

kindly ping @cms-sw/db-l2

Ping @cms-sw/db-l2

+1

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

+1